directxtk Issue Tracker Rss Feed

Created Feature: Implement cone as geometry primitive [921]

walbourn — Wed, 24 Apr 2013 17:32:52 GMT

Hello,

I'm sorry if this is not the right place to request, is there a chance to implement a cone as a geometry primitive in DirectxTK?

the reason is, cones are very useful in implementing spot lights, especially in deferred or pre-pass lightning renderers.

thanks in advance.

Commented Issue: Spritebatch.Draw exception [915]

walbourn — Sun, 14 Apr 2013 06:00:16 GMT

Hi.

I have the following problem with SpriteBatch.Draw():

Unhandled exception at 0x01024A00 in ZXpp.exe: 0xC0000005: Access violation reading location 0x00000000.

I setup the spritebatch with spriteBatch.reset( new SpriteBatch( dContext) );

And .png textures loaded with CreateWICTextureFromFile(...

Sometimes everything just works, but 90%+ of the times it fails with this error - I guess I'm doing something wrong...)

Cheers

James
Comments: ** Comment from web user: walbourn **

If you have a memory leak, uninitialized pointer, or similar problem (as is often indicated by 'Debug' working but 'Release' crashing) then changing the problem significantly can often cause it to seem to go away but it's still there. Make sure you are compiling with Warning Level 4 and fix all warnings. You might even want to go so far as to run Code Analysis on it and check out all messages there too.

Also, DirectSound is deprecated. You should consider [XAUDIO2](http://blogs.msdn.com/b/chuckw/archive/2012/05/15/learning-xaudio2.aspx) or Media Foundation for your audio needs.

Commented Issue: Spritebatch.Draw exception [915]

johara — Sat, 13 Apr 2013 23:33:26 GMT

I understand. Not enough and then too much information.

However, I have tracked down the source of the crash, and its an odd one. The following line at the start of my DirectSound setup method is the cause:

DirectSoundCreate8(NULL, &directSound, NULL);

If I omit this (and obviously the rest of the audio setup) then its goodbye to my crashes.

Cheers

James

Commented Issue: Spritebatch.Draw exception [915]

ShawnHargreaves — Sat, 13 Apr 2013 22:31:44 GMT

You're crashing due to a null pointer read, so you need to look in the debugger to see what data it is trying access that is null. Perhaps 'cache' isn't set? Is 'paper' null? Or 'spriteBatch' itself null?

I don't have time to debug through your whole big program, sorry. A repro app means to put together a small-as-possible standalone app that demonstrates the problem you are having, separated out from the rest of the program. This makes it easier for others to understand, and also has the advantage that a lot of times you will figure out the mistake yourself during the process of putting together the repro app...

Commented Issue: Spritebatch.Draw exception [915]

johara — Sat, 13 Apr 2013 20:39:20 GMT

OK, sorry, I'm just not sure what is helpful and what is noise.

> what is at the line of code where your program is crashing?

spriteBatch->Draw(cache->getBlock(), XMFLOAT2(startX, (borderHeight + (line * 8)) * screenScale), NULL, colors[paper], 0.f, XMFLOAT2(0, 0), screenScale);

getBlock() above calls this method:

ID3D11ShaderResourceView* TextureCache::getBlock()
{
return block;
}

the ID3D11ShaderResourceView* is created by:

block = 0;
string blockName = "pixelSlices\\block.png";
wstring wName = wstring(blockName.begin(), blockName.end());
CreateWICTextureFromFile( device, context, wName.c_str(), nullptr, &block);

> (or even better, seeing a proper repro app)

My full application (a ZX Spectrum emulator) is available from github. the file ula.cpp contains all the spritebatch code, the application setup & loop is in Application.cpp (mostly copied from the toolkit example). The only other file that might be involved as far as i can see is TextureCache.cpp where the textures are initially loaded as above.

See https://github.com/jo215/ZXpp for the full code.

I appreciate it,

James

Commented Issue: Spritebatch.Draw exception [915]

ShawnHargreaves — Sat, 13 Apr 2013 19:29:15 GMT

> ZXpp.exe!ULA::render() Line 248 C++
>
> The above class (ULA) is where the spritebatch lives. render() just calls the spritebatch.draw() stuff...

Sorry, but my telepathic powers are not up to the job of helping you given so little info. You are going to have to provide FAR more detail before anyone else can guess what you are doing wrong.

Starting with, what is at the line of code where your program is crashing? This callstack points to your own code, not inside SpriteBatch. There is a chance the compiler could be inlining some SpriteBatch code into this method body, but more likely it's an error before it even gets as far as calling SpriteBatch.

Without knowing what that line of code is (or even better, seeing a proper repro app) there is nothing I can do to help you.

Commented Issue: Spritebatch.Draw exception [915]

johara — Sat, 13 Apr 2013 12:12:16 GMT

Hi, just to confirm I've now updated to Update 2. Although am x64 my build platform is Win32. Still same problems, everything OK with debug build, exception with release build.

Cheers

James

Commented Issue: Spritebatch.Draw exception [915]

johara — Sat, 13 Apr 2013 11:48:18 GMT

Hi,
Am using x64, standard Visual Studio 2012 compiler - update 1 only - will now d/l update 2.

ZXpp.exe!ULA::render() Line 248 C++

The above class (ULA) is where the spritebatch lives. render() just calls the spritebatch.draw() stuff...

Cheers

James

Commented Issue: Spritebatch.Draw exception [915]

ShawnHargreaves — Fri, 12 Apr 2013 23:10:32 GMT

> ZXpp.exe!ULA::render() Line 248 C++

And what is this line of code?

Commented Issue: Spritebatch.Draw exception [915]

walbourn — Fri, 12 Apr 2013 22:34:43 GMT

What architecture are you using (x86, ARM, x64?) and which compiler exactly? Have you tried installing VS 2012 Update 2?

Commented Issue: Spritebatch.Draw exception [915]

johara — Fri, 12 Apr 2013 21:50:36 GMT

Sorry, you are quite right.

My code is based on the sample app downloaded with the toolkit.

Here is how I load my textures (in a constructor for a class called TextureCache):

TextureCache::TextureCache(ID3D11Device* device, ID3D11DeviceContext* context)
{
// load all textures here
block = 0;
string blockName = "pixelSlices\\block.png";
wstring wName = wstring(blockName.begin(), blockName.end());
CreateWICTextureFromFile( device, context, wName.c_str(), nullptr, &block);

for (int i = 0; i < 256; i++)
{
string name = "pixelSlices\\pixelSlice";
name += to_string(i);
name += ".png";
wstring wideName = wstring(name.begin(), name.end());
g_pTextureRV1[i] = 0;
CreateWICTextureFromFile( device, context, wideName.c_str(), nullptr, &g_pTextureRV1[i] );
}

}

With extraneous code removed i then render like so:

spriteBatch->Begin(SpriteSortMode_Deferred);
spriteBatch->Draw(cache->getBlock(), XMFLOAT2(startX, (borderHeight + (line * 8)) * screenScale), NULL, colors[paper], 0.f, XMFLOAT2(0, 0), screenScale);
spriteBatch->End();

My stack trace is:

> ZXpp.exe!ULA::render() Line 248 C++
ZXpp.exe!Render() Line 301 C++
ZXpp.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpCmdLine, int nCmdShow) Line 78 C++
ZXpp.exe!__tmainCRTStartup() Line 528 C
kernel32.dll!770233aa() Unknown
[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]
ntdll.dll!77829ef2() Unknown
ntdll.dll!77829ec5() Unknown

Interestingly, this bug only happens in release mode. If I change to debug mode, everything works.

Cheers

James

Commented Issue: Spritebatch.Draw exception [915]

ShawnHargreaves — Fri, 12 Apr 2013 19:53:26 GMT

It is impossible to diagnose your problem with so little information.

What is the callstack when it crashes?

What is your code doing? Please provide a repro app.

Created Issue: Spritebatch.Draw exception [915]

johara — Fri, 12 Apr 2013 19:03:45 GMT

Commented Feature: DXUT rewrite based on DirectXTK for Win32 desktop apps [649]

walbourn — Wed, 10 Apr 2013 19:43:23 GMT

The existing "DXUT11" in the legacy DirectX SDK uses D3DX9 or D3DX11, and supports both Direct3D 9 and Direct3D 11.

With DirectXTK, we can rewrite a new DXUT to support samples running as Windows Vista, Windows 7, and Windows 8 Win32 desktop apps that only requires the Windows 8.0 SDK and DirectXTK.

* Supports Direct3D 11.0 only (no Direct3D 9 or Windows XP support)
* DirectXMath usage instead of D3DXMath
* Cleaned up usage for C++11 (Standard Library & STL, const, remove legacy support from Windows 9x/ME/XP)
* Compiles with both VS 2012 and VS 2010+Windows 8.0 SDK
* Use DXERR from <http://blogs.msdn.com/b/chuckw/archive/2012/04/24/where-s-dxerr-lib.aspx>

http://blogs.msdn.com/b/chuckw/archive/2012/03/22/where-is-the-directx-sdk.aspx

Feature wise it will provide:

* Device enumeration
* Basic UI framework for WIn32 desktop samples (including the DXUT keyboard/mouse and GUI widgets)
* Feature Level and resoluton/MSAA settings
* Camera for mouse
* Updated for optional DirectX 11.1 support
* Stereo swap-chain support
* Enable Windows 8.0 SDK DXGI debugging?
* Use VS 2012 "VSPIX" perf APIs
Comments: ** Comment from web user: walbourn **

Sorry, a number of other projects have been taking priority here for the past month or so...

Commented Feature: DXUT rewrite based on DirectXTK for Win32 desktop apps [649]

MVives — Wed, 10 Apr 2013 07:33:44 GMT

Chuck: Any word on the status of this item? Thanks.

Commented Issue: Error building Desktop 2012 [889]

johara — Wed, 20 Mar 2013 18:50:34 GMT

Hi,

when I try to build the toolkit (VS 2012, Win 7), the file wincodec.h throws an error:

"D2D1_PIXEL_FORMAT" is undefined

Can anyone help?

Cheers

James
Comments: ** Comment from web user: johara **

Hi.

I get file not found - vscomponents.dat

Never had vs2008 installed but did (and still do) have vs2010.

I also (still) have the DirectX SDK (June 2010) installed.

As for vs2012, I have the full version, downloaded from Microsofts' Dreamspark site (I'm a student).

Cheers

James

Commented Issue: Error building Desktop 2012 [889]

walbourn — Wed, 20 Mar 2013 17:36:29 GMT

The source of this issue is still a bit of a mystery. Are you using a system you once had VS 2008 and the legacy DirectX SDK installed? Open a command prompt, "cd %LOCALAPPDATA%" "attrib -h vscomponents.dat /s" and see if it actually shows up as a file on your system.

Did you have a preview or RC version of VS 2012 installed on this system?

Closed Issue: Error building Desktop 2012 [889]

walbourn — Tue, 19 Mar 2013 20:50:50 GMT

Hi,

when I try to build the toolkit (VS 2012, Win 7), the file wincodec.h throws an error:

"D2D1_PIXEL_FORMAT" is undefined

Can anyone help?

Cheers

James
Comments: Resolved with changeset 25083.

Closed Issue: SpriteBatch->Draw(...) NOT working with WP8 [869]

walbourn — Tue, 12 Mar 2013 18:11:53 GMT

Hi,

I use the sample : http://www.catalinzima.com/2012/11/getting-started-with-direct3d-on-windows-phone-8-for-2d-game-development/ to display the cat picture.

I replace in BasicRenderer.cpp :
m_spriteBatch->Draw(m_catTexture, XMFLOAT2(50, 50));
BY:
m_spriteBatch->Draw(m_catTexture, XMFLOAT2(50, 50), nullptr, Colors::White, 0.0f, XMFLOAT2(0,0), 1.0f, SpriteEffects::SpriteEffects_None, 0.0f);

It works in Debug and Release with the windows phone emulator and with my device (Nokia Lumia 920).

I added just after the line "m_spriteBatch->Begin();" a loop that do nothing. (See my comment for the example).

It works in Debug and Release with the phone emulator, but it works only in Debug NOT in Release on my device. In Release, I have no error but I can't see the cat picture.

Do you know why the cat is not displayed after adding a loop that do nothing?
Is it a bug in my source code or in DirectXTK or anything else?

To compile the solution, I use the latest version of DirectXTK (January 25, 2013).

Currently, to display the cat with my loop that do nothing, I replace the scale float by a XMFLOAT2:
m_spriteBatch->Draw(m_catTexture, XMFLOAT2(50, 50), nullptr, Colors::White, 0.0f, XMFLOAT2(0,0), XMFLOAT2(1.0f,1.0f), SpriteEffects::SpriteEffects_None, 0.0f);

With this it works in Debug and Release on my Device.

Regards,
AlanLive
Comments: Not able to repro

Commented Issue: DGSLEffect for supporting VS 2012 Content Pipeline [894]

JochenCP — Mon, 11 Mar 2013 22:30:26 GMT

Currently the CMO loader maps to BasicEffect (and eventually SkinnedEffect) which means it always uses built-in shaders. This ignores any pixelShader in the material definition which removes the DGSL authored shaders from the model.
Comments: ** Comment from web user: JochenCP **

I hope it is O.K. to reply in this issues comments section again. I don't want to clutter the work item to much.
Please let me know if you want to take this to an other place...

@ShawnHargreaves:

> I'm not understanding what would CustomEffect provide above and beyond the base IEffect interface?

I see your point here, and I agree.

I kind of contradict myself when saying custom custom custom, but on the other hand introducing restrictions over Apply and GetVertexShaderByteCode...

Well it is there just to fulfill the minimal requirements of EffectFactoryAssetAccess. Effectiveliy covering the minimum requirements almost every effect I could think of has - which is a vertex shader and a pixel shader.

@walbourn:

> Really to get the kind of behavior you are describing, you are supposed to provide your own implementation of IEffectFactory to the loader and do all your magic changes based on material information from there (likely the 'material name' as a tag).

I accidentally also ripped the ": public IEffectFactory " from

_class EffectFactoryAssetAccess : public IEffectFactory, private NonCopyable_

when I pasted the code in here in my last comment. EffectFactoryAssetAccess is this own implementation I apply to the loader. Sorry if this wasn't understandable in the first place.

Just to explain, why I even posted here:
I was looking at the neat Mesh Content Pipline and DGSL editor in 2012... what I was missing was a simple way to put it into my application. By looking around, I found DirectXTK could do it.

However it didn't really work out as smooth as I expected, on one side because of the lack of custom VS support in combination with DGSL editor, but that's a different story, and on the other side because I found the DirectXTK CMO Loader API as used in the example already is kind of specialized in a way that didn't match my requirements.

Sure it's like both of you say the necessary interfaces to utilize CMO loader code are there: IEffect and IEffectFactory, and I ended up deriving from these to get what I needed. I just wanted to supply some input on what helped me get closer to a solution and could also be useful to others.

"DGSLEffect for supporting VS 2012 Content Pipeline" is what I was initially looking for and I would love to use an out of the box DirectXTK solution over my custom one in the future. Especially if it plays well with things like multiple textures, abstract assets loading, render to texture.

Thanks for your comments.

Best Jochen